Repository navigation
fix: resolve symlinks before containment and reject device names and control characters - #717
Merged
Merged
Conversation
|
Warning Review limit reachedThis organization requires a seat for paid usage-based reviews, including automatic and on-demand reviews. Ask an admin to assign a seat or enable paid usage-based reviews for users without a seat in Billing. Next included review available in 59 minutes. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Local path containment was checked lexically, allowing a symlink to resolve outside the root. Windows device names and alternate stream separators were accepted as local paths, and ASCII control characters below DEL were accepted in B2 file names.
Changes
UnsupportedFilename; symlinked roots and internal links remain supported.Verification
CONandfile:stream, and ASCII control character 1 failed against the corresponding unchanged master code before each fix.git diff --check, and towncrier validation passed.noxfile.py.Containment is checked at path validation time; concurrent filesystem changes after the check remain possible. Windows-specific validation was tested using simulated platform selection on macOS; native Windows CI provides the platform check.
Refs #711